lkml.org 
[lkml]   [2012]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] slub: use free_page instead of put_page for freeing kmalloc allocation
On Thu, 2 Aug 2012, Glauber Costa wrote:

> diff --git a/mm/slub.c b/mm/slub.c
> index e517d43..9ca4e20 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3453,7 +3453,7 @@ void kfree(const void *x)
> if (unlikely(!PageSlab(page))) {
> BUG_ON(!PageCompound(page));
> kmemleak_free(x);
> - put_page(page);
> + __free_pages(page, compound_order(page));

Hmmm... put_page would have called put_compound_page(). which would have
called the dtor function. dtor is set to __free_pages() ok which does
mlock checks and verifies that the page is in a proper condition for
freeing. Then it calls free_one_page().

__free_pages() decrements the refcount and then calls __free_pages_ok().

So we loose the checking and the dtor stuff with this patch. Guess that is
ok?

Acked-by: Christoph Lameter <cl@linux.com>



\
 
 \ /
  Last update: 2012-08-02 16:41    [W:0.153 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site