[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[ 20/32] xhci: Add Etron XHCI_TRUST_TX_LENGTH quirk.
    From: Greg KH <>

    3.4-stable review patch. If anyone has any objections, please let me know.


    From: Sarah Sharp <>

    commit 5cb7df2b2d3afee7638b3ef23a5bcb89c6f07bd9 upstream.

    Gary reports that with recent kernels, he notices more xHCI driver

    xhci_hcd 0000:03:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?

    We think his Etron xHCI host controller may have the same buggy behavior
    as the Fresco Logic xHCI host. When a short transfer is received, the
    host will mark the transfer as successfully completed when it should be
    marking it with a short completion.

    Fix this by turning on the XHCI_TRUST_TX_LENGTH quirk when the Etron
    host is discovered. Note that Gary has revision 1, but if Etron fixes
    this bug in future revisions, the quirk will have no effect.

    This patch should be backported to kernels as old as 2.6.36, that
    contain a backported version of commit
    1530bbc6272d9da1e39ef8e06190d42c13a02733 "xhci: Add new short TX quirk
    for Fresco Logic host."

    Signed-off-by: Sarah Sharp <>
    Reported-by: Gary E. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/usb/host/xhci-pci.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/host/xhci-pci.c
    +++ b/drivers/usb/host/xhci-pci.c
    @@ -95,6 +95,7 @@ static void xhci_pci_quirks(struct devic
    pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
    xhci->quirks |= XHCI_RESET_ON_RESUME;
    xhci_dbg(xhci, "QUIRK: Resetting on resume\n");
    + xhci->quirks |= XHCI_TRUST_TX_LENGTH;
    if (pdev->vendor == PCI_VENDOR_ID_VIA)
    xhci->quirks |= XHCI_RESET_ON_RESUME;

     \ /
      Last update: 2012-08-20 07:41    [W:4.304 / U:0.372 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site