lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/9] sound/soc/omap/am3517evm.c: fix error return code
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    It was forgotten to initialize ret to the result of calling
    snd_soc_dai_set_sysclk, unlike at the other calls in the same function.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }

    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    sound/soc/omap/am3517evm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/omap/am3517evm.c b/sound/soc/omap/am3517evm.c
    index 009533a..df65f98 100644
    --- a/sound/soc/omap/am3517evm.c
    +++ b/sound/soc/omap/am3517evm.c
    @@ -59,7 +59,7 @@ static int am3517evm_hw_params(struct snd_pcm_substream *substream,
    return ret;
    }

    - snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0,
    + ret = snd_soc_dai_set_sysclk(cpu_dai, OMAP_MCBSP_FSR_SRC_FSX, 0,
    SND_SOC_CLOCK_IN);
    if (ret < 0) {
    printk(KERN_ERR "can't set CPU system clock OMAP_MCBSP_FSR_SRC_FSX\n");


    \
     
     \ /
      Last update: 2012-08-19 09:41    [W:0.023 / U:32.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site