lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] unifdef: set a secure umask before calling mkstemp()
    On Sat, 18 Aug 2012, Tony Finch wrote:

    > Jesper Juhl <jj@chaosbits.net> wrote:
    >
    > > In newer glibc's (versions > 2.06) reasonably secure permissions of
    > > 0600 are used when creating a temporary file with mkstemp(). But for
    > > older glibc's (versions <= 2.06) 0666 is used which is not secure.
    >
    > Thanks for your suggestion! I'm afraid I prefer not to make the change.
    >
    > Unifdef is only using mkstemp as a convenient way to open a file with a
    > non-clashing name. It isn't trying to be secure, so it's OK just to rely
    > on the user's umask. And I find it hard to care about a bug that was fixed
    > 15 years ago.
    >
    > I'm also trying to reduce the unixisms in the program for portability
    > reasons and this is the most awkward part :-/
    >
    Fair enough. :-)

    Just ignore the patch.

    Have a nice day.

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-08-20 00:21    [W:0.023 / U:94.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site