lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fs: Introducing Lanyard Filesystem
    Il 19/08/2012 18:53, Dan Luedtke ha scritto:
    > On Sun, 2012-08-19 at 15:27 +0100, Al Viro wrote:
    >> * unlimited recursion
    > I am already working on that one, but it's tricky.
    >
    >> * unlink() does *not* truncate the file contents;
    > I did not know that.

    I add that vmtruncate is deprecated and I see a call to inode_dio_wait
    but no support for direct IO. In addition the lock rules seem strange, I
    would avoid playing with inode->i_lock.

    >
    >> * while we are at it, neither of those should free the on-disk
    >> inode; again, that should happen only when the inode is evicted.
    > Makes sense now. Thanks!

    And I think you'll call d_delete two times.

    As general suggestion: to have a general view how things can work you
    can look at other fs. Maybe ramfs or tmpfs are simple enough to
    understand the general concepts.

    Marco



    \
     
     \ /
      Last update: 2012-08-19 18:01    [W:0.028 / U:147.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site