lkml.org 
[lkml]   [2012]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 56/74] lto, workaround: Add workaround for missing LTO symbols in igb
    Date
    From: Andi Kleen <ak@linux.intel.com>

    The gcc 4.7 LTO with -fno-toplevel-reorder sometimes drops data
    variables. These show up as undefined symbols at link time.
    As a workaround just make a few where it happened visible for now.

    There isl nothing wrong with this driver, just a toolchain problem.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    ---
    drivers/net/ethernet/intel/igb/e1000_82575.c | 7 ++++---
    1 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c
    index ba994fb..86b985a 100644
    --- a/drivers/net/ethernet/intel/igb/e1000_82575.c
    +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c
    @@ -2254,7 +2254,8 @@ out:
    return ret_val;
    }

    -static struct e1000_mac_operations e1000_mac_ops_82575 = {
    +/* Workaround for LTO bug */
    +__visible struct e1000_mac_operations e1000_mac_ops_82575 = {
    .init_hw = igb_init_hw_82575,
    .check_for_link = igb_check_for_link_82575,
    .rar_set = igb_rar_set,
    @@ -2262,13 +2263,13 @@ static struct e1000_mac_operations e1000_mac_ops_82575 = {
    .get_speed_and_duplex = igb_get_speed_and_duplex_copper,
    };

    -static struct e1000_phy_operations e1000_phy_ops_82575 = {
    +__visible struct e1000_phy_operations e1000_phy_ops_82575 = {
    .acquire = igb_acquire_phy_82575,
    .get_cfg_done = igb_get_cfg_done_82575,
    .release = igb_release_phy_82575,
    };

    -static struct e1000_nvm_operations e1000_nvm_ops_82575 = {
    +__visible struct e1000_nvm_operations e1000_nvm_ops_82575 = {
    .acquire = igb_acquire_nvm_82575,
    .read = igb_read_nvm_eerd,
    .release = igb_release_nvm_82575,
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-08-19 06:02    [W:0.024 / U:147.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site