[lkml]   [2012]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/1 v4] i2c: Add default configuration into the Nomadik I2C driver.
    On Wed, Aug 08, 2012 at 02:11:59PM +0100, Lee Jones wrote:
    > From: Lee Jones <>
    > Date: Tue, 7 Aug 2012 12:27:24 +0100
    > Subject: [PATCH 1/1 v4] i2c/nomadik: Add default configuration into the Nomadik I2C driver

    Actually, unlike Linus said, I prefer "i2c: nomadik:"; minor nit,

    > At this moment in time there is only one known configuration for the
    > Nomadik I2C driver. By not holding that configuration in the driver
    > adds some unnecessary overhead in platform code. The configuration
    > as already been removed from platform code, this patch checks for any

    ^^ has ( I fixed it )

    > over-riding configurations. If there aren't any, the default is used.
    > Cc:
    > Acked-by: srinidhi kasagar <>
    > Acked-by: Linus Walleij <>
    > Signed-off-by: Lee Jones <>

    Applied to -current, thanks! I added a note from Linus that it is needed
    because of boot regressions. That is also useful in commit messages.

    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | |
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2012-08-18 10:21    [W:0.023 / U:97.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site