lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace
    On Thu, Aug 16, 2012 at 07:20:15PM +0100, Michal Hocko wrote:
    > On Thu 16-08-12 17:09:54, Will Deacon wrote:
    > > +static inline void arch_clear_hugepage_flags(struct page *page)
    > > +{
    > > + flush_dcache_page(page);
    > > +}
    > > +
    >
    > Why do we need the hook for ia64? hugetlb_no_page calls clear_huge_page
    > and that one calls flush_dcache_page (via clear_user_page), right?
    > The same applies to copy_huge_page for COW.

    You're right, these are redundant for ppc and ia64 (although ppc does have a
    comment moaning about the flush). Looks like it's just sh and ARM that need to
    do anything.

    Cheers,

    Will


    \
     
     \ /
      Last update: 2012-08-16 21:21    [W:0.029 / U:30.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site