lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] mmc: card: Skip secure option for MoviNAND.
Date
MMC_QUIRK_SEC_ERASE_TRIM_BROKEN seems quite clear but I might not use "SEC"
due to it could be Samsung Electronics Corporation.
So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in
mmc_blk_issue_secdiscard_rq() naming, the function we skip.
Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN?

Regards,
Ian
-----Original Message-----
From: Linus Walleij [mailto:linus.walleij@linaro.org]
Sent: Tuesday, August 14, 2012 5:07 PM
To: IAN CHEN
Cc: cjb@laptop.org; linkinjeon@gmail.com; adrian.hunter@intel.com;
subhashj@codeaurora.org; linux-mmc@vger.kernel.org;
linux-kernel@vger.kernel.org; d.j.shin@samsung.com;
jongtae22.kim@samsung.com; kyungmin.park@samsung.com; jh80.chung@samsung.com
Subject: Re: [PATCH v3] mmc: card: Skip secure option for MoviNAND.

On Tue, Aug 14, 2012 at 9:06 AM, IAN CHEN <ian.cy.chen@samsung.com> wrote:

> +#define MMC_QUIRK_SECURE_MODE_BROKEN (1<<10) /* Skip secure for
> erase/trim */

OK this will work and sorry for being picky, but we are working with RPMB
support and that's some other "secure mode" so to avoid any
misuderstandings it's better to name the flag like I proposed,
MMC_QUIRK_SEC_ERASE_TRIM_BROKEN

I won't die if this goes in though :-)

Yours,
Linus Walleij



\
 
 \ /
  Last update: 2012-08-16 06:44    [W:0.046 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site