lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper
On Thu, Aug 16, 2012 at 08:47:03AM -0400, J. Bruce Fields wrote:
> > Hi Bruce, thinking a bit more I guess using general encode_fh is not that
> > convenient since it operates with dentries while our fdinfo output deals
> > with inodes. Thus I should either provide some new encode_fh variant
> > which would deal with inodes directly without "parents".
>
> I can't see why that wouldn't work.
>
> > Which doesn't
> > look for me anyhow better than the new export_encode_inode_fh helper.
>
> That isn't going to work for filesystems that define their own
> encode_fh:
>
> $ git grep '\.encode_fh'
> fs/btrfs/export.c: .encode_fh = btrfs_encode_fh,
> fs/ceph/export.c: .encode_fh = ceph_encode_fh,
...

Agreed. I'll try to cook something.


\
 
 \ /
  Last update: 2012-08-16 16:02    [W:0.230 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site