Messages in this thread Patch in this message | | | Date | Thu, 16 Aug 2012 15:25:38 +1000 | From | Stephen Rothwell <> | Subject | linux-next: build failure after merge of the final tree (hid tree related) |
| |
Hi all,
After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this:
drivers/hid/hid-picolcd_fb.c: In function 'picolcd_fb_destroy': drivers/hid/hid-picolcd_fb.c:350:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] drivers/hid/hid-picolcd_fb.c: In function 'picolcd_init_framebuffer': drivers/hid/hid-picolcd_fb.c:508:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration] drivers/hid/hid-picolcd_fb.c:508:12: warning: assignment makes pointer from integer without a cast [enabled by default]
Caused by commit fabdbf2fd22f ("HID: picoLCD: split driver code") from the hid tree.
I added the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Thu, 16 Aug 2012 15:20:10 +1000 Subject: [PATCH] HID: using vmalloc() requires the include of vmalloc.h
Fixes thes build errors:
drivers/hid/hid-picolcd_fb.c: In function 'picolcd_fb_destroy': drivers/hid/hid-picolcd_fb.c:350:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] drivers/hid/hid-picolcd_fb.c: In function 'picolcd_init_framebuffer': drivers/hid/hid-picolcd_fb.c:508:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration] drivers/hid/hid-picolcd_fb.c:508:12: warning: assignment makes pointer from integer without a cast [enabled by default]
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/hid/hid-picolcd_fb.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index 4d8e22c..cf295c5 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -18,6 +18,7 @@ ***************************************************************************/ #include <linux/hid.h> +#include <linux/vmalloc.h> #include "usbhid/usbhid.h" #include <linux/usb.h> -- 1.7.10.280.gaa39 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [unhandled content-type:application/pgp-signature] | |