lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] mmc: card: Skip secure option for MoviNAND.
    On 08/16/2012 01:09 PM, IAN CHEN wrote:
    > MMC_QUIRK_SEC_ERASE_TRIM_BROKEN seems quite clear but I might not use "SEC"
    > due to it could be Samsung Electronics Corporation.
    I didn't think so.
    MMC developers didn't think that SEC means Samsung Electronics Corporation.
    Already we used the flags with "_SEC_"
    It's no problem.

    Best Regards,
    Jaehoon Chung
    > So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in
    > mmc_blk_issue_secdiscard_rq() naming, the function we skip.
    > Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN?
    >
    > Regards,
    > Ian
    > -----Original Message-----
    > From: Linus Walleij [mailto:linus.walleij@linaro.org]
    > Sent: Tuesday, August 14, 2012 5:07 PM
    > To: IAN CHEN
    > Cc: cjb@laptop.org; linkinjeon@gmail.com; adrian.hunter@intel.com;
    > subhashj@codeaurora.org; linux-mmc@vger.kernel.org;
    > linux-kernel@vger.kernel.org; d.j.shin@samsung.com;
    > jongtae22.kim@samsung.com; kyungmin.park@samsung.com; jh80.chung@samsung.com
    > Subject: Re: [PATCH v3] mmc: card: Skip secure option for MoviNAND.
    >
    > On Tue, Aug 14, 2012 at 9:06 AM, IAN CHEN <ian.cy.chen@samsung.com> wrote:
    >
    >> +#define MMC_QUIRK_SECURE_MODE_BROKEN (1<<10) /* Skip secure for
    >> erase/trim */
    >
    > OK this will work and sorry for being picky, but we are working with RPMB
    > support and that's some other "secure mode" so to avoid any
    > misuderstandings it's better to name the flag like I proposed,
    > MMC_QUIRK_SEC_ERASE_TRIM_BROKEN
    >
    > I won't die if this goes in though :-)
    >
    > Yours,
    > Linus Walleij
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    >



    \
     
     \ /
      Last update: 2012-08-16 06:44    [W:0.028 / U:32.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site