lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V5 13/18] drm: Define SAREA_MAX for Loongson (PageSize = 16KB).
    From
    On Thu, Aug 16, 2012 at 5:31 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
    > On Sat, Aug 11, 2012 at 05:32:18PM +0800, Huacai Chen wrote:
    >
    >> Subject: [PATCH V5 13/18] drm: Define SAREA_MAX for Loongson (PageSize = 16KB).
    >
    > But your code doesn't define it just for Loongsson as the log message claims
    > but rather for all MIPS.
    >
    >> diff --git a/include/drm/drm_sarea.h b/include/drm/drm_sarea.h
    >> index ee5389d..1d1a858 100644
    >> --- a/include/drm/drm_sarea.h
    >> +++ b/include/drm/drm_sarea.h
    >> @@ -37,6 +37,8 @@
    >> /* SAREA area needs to be at least a page */
    >> #if defined(__alpha__)
    >> #define SAREA_MAX 0x2000U
    >> +#elif defined(__mips__)
    >> +#define SAREA_MAX 0x4000U
    >
    > How about replacing this whole #ifdef mess with something like:
    >
    > #include <linux/kernel.h>
    > #include <asm/page.h>
    >
    > /* Intel 830M driver needs at least 8k SAREA */
    > #define SAREA_MAX max(PAGE_SIZE, 0x2000U)
    >
    > MIPS also uses 64K page size and your patch as posted would break with 64k
    > pages.
    Yes, I think this is better. Thank you.
    >
    > Ralf


    \
     
     \ /
      Last update: 2012-08-16 03:23    [W:0.023 / U:60.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site