lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/14] atm: fix info leak via getsockname()
    Date
    The ATM code fails to initialize the two padding bytes of struct
    sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
    before filling the structure to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    ---
    net/atm/pvc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/atm/pvc.c b/net/atm/pvc.c
    index 3a73491..ae03240 100644
    --- a/net/atm/pvc.c
    +++ b/net/atm/pvc.c
    @@ -95,6 +95,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr,
    return -ENOTCONN;
    *sockaddr_len = sizeof(struct sockaddr_atmpvc);
    addr = (struct sockaddr_atmpvc *)sockaddr;
    + memset(addr, 0, sizeof(*addr));
    addr->sap_family = AF_ATMPVC;
    addr->sap_addr.itf = vcc->dev->number;
    addr->sap_addr.vpi = vcc->vpi;
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2012-08-16 00:42    [W:0.026 / U:0.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site