lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 11/13] vfs: export __inode_permission() to modules
    From
    On Wed, Aug 15, 2012 at 5:48 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
    > From: Miklos Szeredi <mszeredi@suse.cz>
    >
    > We need to be able to check inode permissions (but not filesystem implied
    > permissions) for stackable filesystems. Expose this interface for overlayfs.
    >

    This patch can go through Al's vfs tree?
    It's an addendum for the below patch "VFS: Split inode_permission()"
    [1] from the first pile of vfs patches for v3.6-rc1 (first bits of/for
    union-mounts!).
    I talked with Andy on #ubuntu-kernel that the export is needed when
    OverlayFS is built as a module.

    Comments?

    - Sedat -

    [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=0bdaea9017b9d2b9996e153a71ee03555969b80e

    > Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    > ---
    > fs/internal.h | 5 -----
    > fs/namei.c | 1 +
    > include/linux/fs.h | 1 +
    > 3 files changed, 2 insertions(+), 5 deletions(-)
    >
    > diff --git a/fs/internal.h b/fs/internal.h
    > index 371bcc4..8578209 100644
    > --- a/fs/internal.h
    > +++ b/fs/internal.h
    > @@ -42,11 +42,6 @@ static inline int __sync_blockdev(struct block_device *bdev, int wait)
    > extern void __init chrdev_init(void);
    >
    > /*
    > - * namei.c
    > - */
    > -extern int __inode_permission(struct inode *, int);
    > -
    > -/*
    > * namespace.c
    > */
    > extern int copy_mount_options(const void __user *, unsigned long *);
    > diff --git a/fs/namei.c b/fs/namei.c
    > index ac2526d..9be439a 100644
    > --- a/fs/namei.c
    > +++ b/fs/namei.c
    > @@ -348,6 +348,7 @@ int __inode_permission(struct inode *inode, int mask)
    >
    > return security_inode_permission(inode, mask);
    > }
    > +EXPORT_SYMBOL(__inode_permission);
    >
    > /**
    > * sb_permission - Check superblock-level permissions
    > diff --git a/include/linux/fs.h b/include/linux/fs.h
    > index 1265e24..d573703 100644
    > --- a/include/linux/fs.h
    > +++ b/include/linux/fs.h
    > @@ -2418,6 +2418,7 @@ extern sector_t bmap(struct inode *, sector_t);
    > #endif
    > extern int notify_change(struct dentry *, struct iattr *);
    > extern int inode_permission(struct inode *, int);
    > +extern int __inode_permission(struct inode *, int);
    > extern int generic_permission(struct inode *, int);
    >
    > static inline bool execute_ok(struct inode *inode)
    > --
    > 1.7.7
    >


    \
     
     \ /
      Last update: 2012-08-15 20:04    [W:0.038 / U:0.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site