lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] s390: Always use "long" for ssize_t to match size_t
On Sun, Aug 12, 2012 at 12:01:34PM +0200, Geert Uytterhoeven wrote:
> On s390x-linux-gcc, __SIZE_TYPE__ expands to "long unsigned int" for both
> 32-bit s390 and 64-bit s390x, as
> gcc-4.6.3-nolibc/s390x-linux/lib/gcc/s390x-linux/4.6.3/plugin/include/config/s390/linux.h
> has
>
> #define SIZE_TYPE (TARGET_64BIT ? "long unsigned int" : "long unsigned int")
>
> To match this, __kernel_size_t is always set to "long unsigned int".
>
> But while __kernel_ssize_t is "long" on 64-bit s390x, it is "int" on 32-bit
> s390, causing compiler warnings like:
>
> fs/quota/quota_tree.c:372:4: warning: format '%zd' expects argument of type 'signed size_t', but argument 4 has type 'ssize_t' [-Wformat]
>
> To fix this, __kernel_ssize_t should be "long", irrespective of word size.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied. Thanks Geert!



\
 
 \ /
  Last update: 2012-08-15 10:42    [W:0.028 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site