lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 30/31] arm64: Build infrastructure
Date
On Tuesday 14 August 2012, Catalin Marinas wrote:

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> new file mode 100644
> index 0000000..1ce3d04
> --- /dev/null
> +++ b/arch/arm64/Kconfig
> @@ -0,0 +1,261 @@
> +config ARM64
> + def_bool y
> + select OF
> + select OF_EARLY_FLATTREE
> + select IRQ_DOMAIN
> + select HAVE_AOUT
> + select HAVE_DMA_ATTRS
> + select HAVE_DMA_API_DEBUG
> + select HAVE_IDE

Please remove HAVE_AOUT and HAVE_IDE

> + select HAVE_MEMBLOCK
> + select RTC_LIB
> + select SYS_SUPPORTS_APM_EMULATION

APM_EMULATION can probably go too

> +
> +config ARCH_PHYS_ADDR_T_64BIT
> + def_bool y
> +
> +config HAVE_PWM
> + bool

HAVE_PWM is going away soon.

> +config AARCH32_EMULATION
> + bool "Kernel support for 32-bit EL0"
> + depends on !ARM64_64K_PAGES
> + select COMPAT_BINFMT_ELF
> + help
> + This option enables support for a 32-bit EL0 running under a 64-bit
> + kernel at EL1. AArch32-specific components such as system calls,
> + the user helper functions, VFP support and the ptrace interface are
> + handled appropriately by the kernel.
> +
> + If you want to execute 32-bit userspace applications, say Y.
> +
> +config COMPAT
> + def_bool y
> + depends on AARCH32_EMULATION

As mentioned, you can just merge the two into CONFIG_COMPAT.

> +targets := Image Image.gz
> +
> +$(obj)/Image: vmlinux FORCE
> + $(call if_changed,objcopy)
> + @echo ' Kernel: $@ is ready'
> +
> +$(obj)/Image.gz: $(obj)/Image FORCE
> + $(call if_changed,gzip)
> + @echo ' Kernel: $@ is ready'

Drop the useless output, at least when building with make -s.

> +if [ -x /sbin/loadmap ]; then
> + /sbin/loadmap
> +else
> + echo "You have to install it yourself"
> +fi

What is loadmap?

> diff --git a/arch/arm64/configs/generic_defconfig b/arch/arm64/configs/generic_defconfig
> new file mode 100644
> index 0000000..d9aac95
> --- /dev/null
> +++ b/arch/arm64/configs/generic_defconfig

I think it can just be called "defconfig".

> diff --git a/arch/arm64/mm/Kconfig b/arch/arm64/mm/Kconfig
> new file mode 100644
> index 0000000..8e94e52
> --- /dev/null
> +++ b/arch/arm64/mm/Kconfig
> @@ -0,0 +1,5 @@
> +config MMU
> + def_bool y
> +
> +config CPU_64
> + def_bool y

This file can be dropped. You can unconditionally enable CONFIG_MMU,
and the CPU_64 symbol is pointless, just use CONFIG_64BIT.

Arnd


\
 
 \ /
  Last update: 2012-08-15 18:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site