Messages in this thread | | | Subject | Re: [PATCH] act_mirred: do not drop packets when fails to mirror it | From | Jamal Hadi Salim <> | Date | Wed, 15 Aug 2012 11:10:19 -0400 |
| |
On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote:
> > I met it actually through the following steps: > > - start a kvm guest with tap and make it to be an interface of the bridge > - mirror the ingress traffic of the bridge to the tap > - terminate the qemu process, the tap device is then removed > - all packet goes to bridge would be dropped, so the network of guests > in the same bridge would be broken >
Makes sense. Can you please leave the err check braces i.e if (err) { m->tcf_qstats.overlimits++; if (m->tcfm_eaction != TCA_EGRESS_MIRROR) retval = TC_ACT_SHOT; else retval = m->tcf_action; } else { retval = m->tcf_action; }
Or at least dont use TC_ACT_STOLEN.
cheers, jamal
| |