lkml.org 
[lkml]   [2012]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers
    On Wed, Aug 15, 2012 at 02:21:47AM +0400, Cyrill Gorcunov wrote:
    > > Hmm, in very first versions I've been using one ->show method, but
    > > then I thought that this is not very correlate with seq-files idea
    > > where for each record show/next sequence is called. I'll update (this
    > > for sure will make code simplier, and I'll have to check for seq-file
    > > overflow after seq_printf call to not continue printing data for too
    > > long if buffer already out of space).
    >
    > Al, I'll cook the whole series tomorrow and resend it for review,
    > also I guess the new show_fdinfo() member in file-operations should
    > be guarded with CONFIG_PROC_FS, right?

    I seriously doubt that it's worth bothering. If somebody cares, they
    can add making it conditional later.


    \
     
     \ /
      Last update: 2012-08-15 02:43    [W:0.024 / U:128.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site