lkml.org 
[lkml]   [2012]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC
    On Thu, 26 Jul 2012 12:05:19 +0530
    Venu Byravarasu <vbyravarasu@nvidia.com> wrote:

    > TPS65910 PMIC is a MFD with RTC as one of the device.
    > Adding RTC driver for supporting RTC device present
    > inside TPS65910 PMIC.
    >
    > Only support for RTC alarm is implemented as part of this patch.

    It needs a build fix:

    drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_suspend':
    drivers/rtc/rtc-tps65910.c:313: error: request for member 'irqstat' in something not a structure or union
    drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_resume':
    drivers/rtc/rtc-tps65910.c:327: error: request for member 'irqstat' in something not a structure or union

    --- a/drivers/rtc/rtc-tps65910.c~rtc-tps65910-add-rtc-driver-for-tps65910-pmic-rtc-fix
    +++ a/drivers/rtc/rtc-tps65910.c
    @@ -310,7 +310,7 @@ static int tps65910_rtc_suspend(struct p

    /* Store current list of enabled interrupts*/
    ret = regmap_read(tps->regmap, TPS65910_RTC_INTERRUPTS,
    - &tps->rtc.irqstat);
    + &tps->rtc->irqstat);
    if (ret < 0)
    return ret;

    @@ -324,7 +324,7 @@ static int tps65910_rtc_resume(struct pl

    /* Restore list of enabled interrupts before suspend */
    return regmap_write(tps->regmap, TPS65910_RTC_INTERRUPTS,
    - tps->rtc.irqstat);
    + tps->rtc->irqstat);
    }

    static const struct dev_pm_ops tps65910_rtc_pm_ops = {

    but it still has problems:

    drivers/rtc/rtc-tps65910.c:331: warning: initialization from incompatible pointer type
    drivers/rtc/rtc-tps65910.c:332: warning: initialization from incompatible pointer type

    fix and resend, please?


    \
     
     \ /
      Last update: 2012-08-15 02:22    [W:0.024 / U:35.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site