Messages in this thread | | | Date | Tue, 14 Aug 2012 16:05:52 +0200 | From | Bernhard Froemel <> | Subject | Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Please reduce the delay in the gmux_index_wait_[ready|complete] functions: 100ms is way too long. 1 ms is more than enough. I never experienced any problems with 100 us.
The version information can also be extracted in the new gmux device (see my initial patch proposal).
Bernhard
On 08/14/2012 02:46 AM, Seth Forshee wrote: > On Mon, Aug 13, 2012 at 06:52:49PM -0400, Matthew Garrett wrote: >> New gmux devices have a different method for accessing the >> registers. Update the driver to cope. Incorporates feedback from >> Bernhard Froemel. >> >> Signed-off-by: Matthew Garrett <mjg@redhat.com> Cc: Bernhard >> Froemel <froemel@vmars.tuwien.ac.at> Cc: Seth Forshee >> <seth.forshee@canonical.com> > > Acked-by: Seth Forshee <seth.forshee@canonical.com> >
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlAqWz8ACgkQ6iVUjPs37Jny4QCgvIj24lw/hpSF35P3k7vKcxtt xj4AoNdN4u1QE4YErj771aP2ArZMDOS1 =TJHi -----END PGP SIGNATURE-----
| |