Messages in this thread | | | From | <> | Subject | RE: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev() | Date | Tue, 14 Aug 2012 12:36:12 +0000 |
| |
>-----Original Message----- >From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >Behalf Of Ilya Shchepetkov > >For carrier detection to work properly when binding the driver with a >cable unplugged, netif_carrier_off() should be called after >register_netdev(), not before. > >Calling netif_carrier_off() before register_netdev() was causing the >network interface to miss a linkwatch pending event leading to an >inconsistent state if the link is not up when interface is initialized.
ndo_open() may be called as soon register_netdev() completes... When netif_carrier_off() is called *after* register_netdev(), isn't there a possibility of a ndo_open()->netif_carrier_on() call racing this call, causing incorrect results?
| |