lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/6] floppy: do put_disk on current dr if blk_init_queue fails
    From
    Date
    On Mon, 2012-08-13 at 15:16 -0300, Herton Ronaldo Krzesinski wrote:
    > If blk_init_queue fails, we do not call put_disk on the current dr
    > (dr is decremented first in the error handling loop).
    >
    > Cc: stable@vger.kernel.org
    > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>

    Reviewed-by: Ben Hutchings <ben@decadent.org.uk>

    > ---
    > drivers/block/floppy.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
    > index c8d9e68..1e09e99 100644
    > --- a/drivers/block/floppy.c
    > +++ b/drivers/block/floppy.c
    > @@ -4151,6 +4151,7 @@ static int __init do_floppy_init(void)
    >
    > disks[dr]->queue = blk_init_queue(do_fd_request, &floppy_lock);
    > if (!disks[dr]->queue) {
    > + put_disk(disks[dr]);
    > err = -ENOMEM;
    > goto out_put_disk;
    > }

    --
    Ben Hutchings
    I say we take off; nuke the site from orbit. It's the only way to be sure.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-08-14 04:42    [W:0.530 / U:0.020 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean