lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 04/65] SUNRPC: return negative value in case rpcbind client creation error
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Stanislav Kinsbursky <skinsbursky@parallels.com>

    commit caea33da898e4e14f0ba58173e3b7689981d2c0b upstream.

    Without this patch kernel will panic on LockD start, because lockd_up() checks
    lockd_up_net() result for negative value.
    >From my pow it's better to return negative value from rpcbind routines instead
    of replacing all such checks like in lockd_up().

    Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/sunrpc/rpcb_clnt.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/sunrpc/rpcb_clnt.c
    +++ b/net/sunrpc/rpcb_clnt.c
    @@ -251,7 +251,7 @@ static int rpcb_create_local_unix(struct
    if (IS_ERR(clnt)) {
    dprintk("RPC: failed to create AF_LOCAL rpcbind "
    "client (errno %ld).\n", PTR_ERR(clnt));
    - result = -PTR_ERR(clnt);
    + result = PTR_ERR(clnt);
    goto out;
    }

    @@ -298,7 +298,7 @@ static int rpcb_create_local_net(struct
    if (IS_ERR(clnt)) {
    dprintk("RPC: failed to create local rpcbind "
    "client (errno %ld).\n", PTR_ERR(clnt));
    - result = -PTR_ERR(clnt);
    + result = PTR_ERR(clnt);
    goto out;
    }




    \
     
     \ /
      Last update: 2012-08-14 02:21    [W:0.031 / U:60.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site