lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] TTY: mxser, fix invalid module_parm permissions
    Date
    444 means 0674 and we do not definitely want that. Use S_IRUGO which
    is much more safer.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Reported-by: Rusty Russell <rusty@ozlabs.org>
    ---

    Sorry for multiple copies (if any).

    drivers/tty/mxser.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
    index 8bc2651..bb2da4c 100644
    --- a/drivers/tty/mxser.c
    +++ b/drivers/tty/mxser.c
    @@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = {
    */

    static bool allow_overlapping_vector;
    -module_param(allow_overlapping_vector, bool, 444);
    +module_param(allow_overlapping_vector, bool, S_IRUGO);
    MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)");

    static bool mxser_overlapping_vector(struct mxser_board *brd)
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2012-08-13 11:03    [W:0.022 / U:0.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site