lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 52/65] target: Fix reading of data length fields for UNMAP commands
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit 1a5fa4576ec8a462313c7516b31d7453481ddbe8 upstream.

    The UNMAP DATA LENGTH and UNMAP BLOCK DESCRIPTOR DATA LENGTH fields
    are in the unmap descriptor (the payload transferred to our data out
    buffer), not in the CDB itself. Read them from the correct place in
    target_emulated_unmap.

    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    [bwh: Backported to 3.2: adjust filename, context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/target/target_core_cdb.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/target/target_core_cdb.c
    +++ b/drivers/target/target_core_cdb.c
    @@ -1022,7 +1022,6 @@ int target_emulate_unmap(struct se_task
    struct se_cmd *cmd = task->task_se_cmd;
    struct se_device *dev = cmd->se_dev;
    unsigned char *buf, *ptr = NULL;
    - unsigned char *cdb = &cmd->t_task_cdb[0];
    sector_t lba;
    unsigned int size = cmd->data_length, range;
    int ret = 0, offset;
    @@ -1038,11 +1037,12 @@ int target_emulate_unmap(struct se_task
    /* First UNMAP block descriptor starts at 8 byte offset */
    offset = 8;
    size -= 8;
    - dl = get_unaligned_be16(&cdb[0]);
    - bd_dl = get_unaligned_be16(&cdb[2]);

    buf = transport_kmap_data_sg(cmd);

    + dl = get_unaligned_be16(&buf[0]);
    + bd_dl = get_unaligned_be16(&buf[2]);
    +
    ptr = &buf[offset];
    pr_debug("UNMAP: Sub: %s Using dl: %hu bd_dl: %hu size: %hu"
    " ptr: %p\n", dev->transport->name, dl, bd_dl, size, ptr);



    \
     
     \ /
      Last update: 2012-08-14 01:02    [W:0.037 / U:91.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site