lkml.org 
[lkml]   [2012]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86, pci: Fix all early PCI scans to check the vendor ID first
    On Fri, Aug 10, 2012 at 04:57:02PM -0700, H. Peter Anvin wrote:
    > On 08/09/2012 03:34 PM, Betty Dall wrote:
    > >
    > > I thought this should be a break instead of a continue since the code
    > > does a break if the class is 0xffffffff. If the function does not have a
    > > valid VENDOR_ID, then the remaining function numbers do not have to be
    > > scanned because functions are required to be implemented in order (no
    > > skipping a function number.)
    > >
    >
    > Is that true? This is certainly not true in PCI in general: there is
    > required to be a function 0, but there is no guarantee that functions
    > 1-7 don't have gaps.

    These scans are for special known devices, presumably true for them.

    Anwyays if you don't like it please use v1 of the patch.

    -Andi
    --
    ak@linux.intel.com -- Speaking for myself only


    \
     
     \ /
      Last update: 2012-08-11 13:42    [W:0.024 / U:60.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site