| Date | Sat, 11 Aug 2012 11:12:55 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 1/6] ARM: dove: unify clock setup |
| |
Hi Sebastian
> -static void __init clk_init(void) > +static void __init dove_clk_init(void) > { > tclk = clk_register_fixed_rate(NULL, "tclk", NULL, CLK_IS_ROOT, > - get_tclk()); > + dove_tclk); > > orion_clkdev_init(tclk); > + > + /* Ensure tclk is always clocked */ > + clk_prepare_enable(tclk); > }
"ticking" would be better than clocked.
Since this is a root fixed clock, is it necessary to prepare_enable() it? I think prepare and enable become NOPs in this situation.
Andrew
|