lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe:
    From
    Date
    Hi!

    On Fre, 2012-08-10 at 11:02 +0530, devendra.aaru wrote:
    [...]
    > In function tegra_pinctrl_dt_node_to_map the num_maps the num_maps
    > counter must be incremented for each child node?
    >
    > Actually we are doing free until num_maps if tegra_pinctrl_dt_subnode_to_map,
    >
    > not only that if num_maps == 0, we wont free up the maps, and also i
    > think the for_each_of_node checks whether we have a next child node,
    > so its safe to do num_maps++ as it wont get incremented endlessly,
    [...]

    Not that I looked into the source but ....

    > diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c
    > index ae52e4e..33ae918 100644
    > --- a/drivers/pinctrl/pinctrl-tegra.c
    > +++ b/drivers/pinctrl/pinctrl-tegra.c
    > @@ -303,6 +303,7 @@ int tegra_pinctrl_dt_node_to_map(struct
    > pinctrl_dev *pctldev,
    ... num_maps appears to be a pointer to the counter here and ...
    > *num_maps = 0;
    >
    > for_each_child_of_node(np_config, np) {
    ... here you increment the pointer as such and where it points to (which
    appears to be the counter).
    > + num_maps++;
    > ret = tegra_pinctrl_dt_subnode_to_map(pctldev->dev, np, map,
    > &reserved_maps, num_maps);
    > if (ret < 0) {

    Kinf regards,
    Bernd
    --
    Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
    LUGA : http://www.luga.at


    \
     
     \ /
      Last update: 2012-08-10 13:22    [W:0.023 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site