lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] wm831x-dcdc: fix coccinelle warnings of missing IRQF_ONESHOT
On Fri, Aug 10, 2012 at 08:58:24AM +0800, Feng Tang wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:829:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:695:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:533:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
> /c/kernel-tests/src/linux/drivers/regulator/wm831x-dcdc.c:542:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

> Make sure threaded IRQs without a primary handler are always request with
> IRQF_ONESHOT

This is actually a false positive - _ONESHOT is only needed for
interrupts without a primary handler if the interrupt controller is not
threaded. For this driver (and most of the other wm831x drivers, as
well as many other MFDs) we are guaranteed that the primary handler can
never be called. It's not going to hurt, though.


\
 
 \ /
  Last update: 2012-08-10 12:42    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site