lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpio: Add Avionic Design N-bit GPIO expander support
On Fri, Aug 10, 2012 at 10:41:58AM +0200, Linus Walleij wrote:
> On Fri, Aug 10, 2012 at 10:35 AM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> >> Consult the following article on LWN:
> >> http://lwn.net/Articles/470820/
> >>
> >> Then grep your gitlog and you'll see we got rid of it from ARM.
> >
> > Then why is there still the following in arch/arm/include/asm/irq.h?
> >
> > /*
> > * Use this value to indicate lack of interrupt
> > * capability
> > */
> > #ifndef NO_IRQ
> > #define NO_IRQ ((unsigned int)(-1))
> > #endif
>
> That's a question for Russell but I think it's basically there for
> old platforms, on a "don't use it"-basis. (Maybe a comment could
> be good.)

Just don't use it. It's there for old stuff which still needs fixing.

New code should not use it, and should test for one of:

irq <= 0
irq == 0

And new code should set irq = 0 to indicate a lack of interrupt.


\
 
 \ /
  Last update: 2012-08-10 12:03    [W:0.047 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site