lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/11] spi/s3c64xx: improve error handling
Date
On Friday 10 August 2012, Kukjin Kim wrote:

> BTW for same reason, probably, we need following fix?
>
> arch/arm/mach-tegra/tegra2_emc.c | 4 ++--
> arch/c6x/kernel/setup.c | 2 +-
> arch/powerpc/kernel/ibmebus.c | 2 +-
> arch/powerpc/kernel/pci_of_scan.c | 2 +-
> arch/powerpc/kernel/prom.c | 2 +-
> arch/powerpc/kernel/rtas_pci.c | 2 +-
> arch/powerpc/kernel/vio.c | 2 +-
> arch/powerpc/platforms/44x/warp.c | 2 +-
> ...

Actually not. The difference is that only s3c64xx_get_slave_ctrldata
accesses the node pointer outside of the look (after break).
This fails when there are no child nodes at all. In the other
cases, the only use of the node pointer is inside the loop,
where it is guaranteed to be valid.

Arnd


\
 
 \ /
  Last update: 2012-08-10 10:22    [W:0.349 / U:0.752 seconds]
©2003-2014 Jasper Spaans. Advertise on this site