lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/16] perf symbol: correct comment wrt kallsyms loading
    Date
    In kallsyms_parse() when calling process_symbol() (a callback argument
    to kallsyms_parse()), we pass start as both start & end (ie:
    start=start, end=start).

    In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1',
    making the length 1, not 0.

    Essentially, start & end define an inclusive range.

    Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
    ---
    tools/perf/util/symbol.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
    index f02de8a..891f83c 100644
    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -605,7 +605,7 @@ int kallsyms__parse(const char *filename, void *arg,

    /*
    * module symbols are not sorted so we add all
    - * symbols with zero length and rely on
    + * symbols, setting length to 1, and rely on
    * symbols__fixup_end() to fix it up.
    */
    err = process_symbol(arg, symbol_name,
    --
    1.7.11.3


    \
     
     \ /
      Last update: 2012-08-11 01:02    [W:0.022 / U:1.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site