lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb
> I guess that length of 1 effectively same as zero length in this case
> since we end up calling symbols__fixup_end. The 'end - start + 1' part
> looks like a leftover from previous change and not needed anymore -
> KSYM_NAME_LEN check too, IMHO - so I suggest using 0 length to make it
> clear.

Got it.

> And it seems you need to rebase the series onto Arnaldo's current
> perf/core branch which separates out ELF bits to symbol-elf.c.

Will do. It apparently wasn't pushed out when I sent these patches, look
for v2 shortly.



\
 
 \ /
  Last update: 2012-08-10 20:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site