Messages in this thread | | | Date | Fri, 10 Aug 2012 08:48:15 -0700 | From | Guenter Roeck <> | Subject | Re: [lm-sensors] NULL dereference BUG in sch56xx_init() |
| |
On Fri, Aug 10, 2012 at 10:35:59AM +0200, Hans de Goede wrote: > Hi, > > On 08/09/2012 04:42 PM, Guenter Roeck wrote: > >On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote: > >>Hi Guenter, > >> > >>This commit triggered an oops which can be fixed by the attached diff. > >>Should it be folded into the original one (preferable for me), or be > >>resent as a standalone patch? > >> > >I folded it into the original commit. > > > >Thanks a lot for the test and feedback! > > Fengguang, good catch, thanks! > > Guenter, 2 remarks: > > 1) The changing of the type of the address parameter of sch56xx_device_add is > not necessary
Yes, I know. I took it in anyway because it reduces code size by another 8 bytes.
> 2) A similar change is needed for the f71882fg, there the type of the address > variable in f71882fg_init() needs to be changed to int too. > Noticed, and fixed. I merged the fix for both into the original patched for simplicity.
Thanks, Guenter
| |