lkml.org 
[lkml]   [2012]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
    On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote:
    > On 31/07/12 16:18, Mark Brown wrote:

    > >I'm not going to apply this patch. This isn't a vendor BSP, we
    > >shouldn't be putting random hacks like this in core code.

    > BSP kernel or otherwise, it still seems wrong to me to fail and
    > entire audio driver just because of a broken link.

    No, really. Random disconnections in the DAPM graph are just endless
    pain from a support and debug point of view. This isn't something that
    randomly breaks on specific hardware where we'd expect random errors at
    runtime, it's something that will never have worked - it seems clear
    nobody tested the mainline submission.

    It's very disappointing to see such an error exist, and even more
    disappointing that there's no interest in fixing the driver.


    \
     
     \ /
      Last update: 2012-08-01 16:01    [W:0.023 / U:30.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site