lkml.org 
[lkml]   [2012]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH can-next v5 2/2] can: flexcan: add LED trigger support
    On 08/01/2012 02:24 PM, Fabio Baltieri wrote:
    > On Wed, Aug 01, 2012 at 01:53:22PM +0200, Marc Kleine-Budde wrote:
    > [...]
    >>> @@ -635,6 +638,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id)
    >>> if (reg_iflag1 & (1 << FLEXCAN_TX_BUF_ID)) {
    >>> stats->tx_bytes += can_get_echo_skb(dev, 0);
    >>> stats->tx_packets++;
    >>> + can_led_event(dev, CAN_LED_EVENT_TX);
    >>
    >> Should the led blink on TX or TX completion interrupt?
    >
    > I'd say on complention interrupt, together with can_get_echo_skb().

    Yes, good that we already agreed on this :D

    Marc
    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Industrial Linux Solutions | Phone: +49-231-2826-924 |
    Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
    Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-08-01 15:01    [W:0.027 / U:30.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site