Messages in this thread | | | Date | Mon, 09 Jul 2012 00:18:18 -0700 (PDT) | Subject | Re: [PATCH v2] cgroup: fix panic in netprio_cgroup | From | David Miller <> |
| |
From: Gao feng <gaofeng@cn.fujitsu.com> Date: Thu, 5 Jul 2012 17:28:40 +0800
> we set max_prioidx to the first zero bit index of prioidx_map in > function get_prioidx. > > So when we delete the low index netprio cgroup and adding a new > netprio cgroup again,the max_prioidx will be set to the low index. > > when we set the high index cgroup's net_prio.ifpriomap,the function > write_priomap will call update_netdev_tables to alloc memory which > size is sizeof(struct netprio_map) + sizeof(u32) * (max_prioidx + 1), > so the size of array that map->priomap point to is max_prioidx +1, > which is low than what we actually need. > > fix this by adding check in get_prioidx,only set max_prioidx when > max_prioidx low than the new prioidx. > > Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Applied.
| |