lkml.org 
[lkml]   [2012]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros
From
Date
On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> Hi kernel guys!
>
> This patchset aims to clean all unused and commented macros.
>
> For this challenge, forgotten-macros tool helped us.

Perhaps there may be false positives in your code.

Many times, macros like the below are used:

#define SUBSYSTEM_PREFIX_FOO 1
#define SUBSYSTEM_PREFIX_BAR 2
#define SUBSYSTEM_PREFIX_BAZ 3

#define USE_TYPE(type) SUBSYSTEM_PREFIX_##type

It doesn't seem your code knows that style.

Also, the tool might be more flexible if it was
written using perl or python.




\
 
 \ /
  Last update: 2012-07-09 07:02    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site