lkml.org 
[lkml]   [2012]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] rcu: Allow rcu_user_enter()/exit() to nest
On Fri, Jul 06, 2012 at 09:27:09AM -0700, Paul E. McKenney wrote:
> On Fri, Jul 06, 2012 at 02:00:14PM +0200, Frederic Weisbecker wrote:
> > Allow calls to rcu_user_enter() even if we are already
> > in userspace (as seen by RCU) and allow calls to rcu_user_exit()
> > even if we are already in the kernel.
> >
> > This makes the APIs more flexible to be called from architectures.
> > Exception entries for example won't need to know if they come from
> > userspace before calling rcu_user_exit().
>
> You lost me on this one. As long as the nesting level stays below
> a few tens, rcu_user_enter() and rcu_user_exit() already can nest.
>
> Or are you saying that you need to deal with duplicate rcu_user_enter()
> calls that must be matched by a single rcu_user_exit() call?

Yep, we can have that kind of thing:

in_user = 1
==== syscall
rcu_user_exit() // in_user = 0
==== exception
rcu_user_exit()
==== end of exception
==== end of syscall
rcu_user_enter()
This is because when we enter an exception, we don't have a different
entry whenever we trapped/faulted in userspace or kernelspace. So it's hard
to know if we were in userspace before the exception triggered. To avoid
complication in architecture code, I'm using this kind of "in_user" state.


\
 
 \ /
  Last update: 2012-07-09 20:21    [from the cache]
©2003-2011 Jasper Spaans