Messages in this thread | | | Date | Mon, 9 Jul 2012 10:28:31 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory |
| |
On Mon, Jul 09, 2012 at 10:22:20AM -0700, Tejun Heo wrote: > > Changing subsys_bits via remount is being deprecated. No need to > > worry about this. > > Also, why does this matter? The xattrs are kept in cgrp anyway. Why > does keeping dentry/inode around make difference?
Ah, okay, the file xattrs are kept in cfe which goes away on file deletion. :)
While changing subsys via remount is going away, I think removing files selectively is still nice to have (even for single hierarchy). I wish it were implemented differently tho. As cgroup_rm_file() already has @cft argument, wouldn't it be better to e.g. add @subsys arg to cgroup_clear_directory() and let that walk subsys->cftsets instead?
Thanks.
-- tejun
| |