lkml.org 
[lkml]   [2012]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events
    Date
    Hi Kishon,


    >-----Original Message-----
    >From: ABRAHAM, KISHON VIJAY
    >Sent: Tuesday, July 03, 2012 10:48 PM
    >To: Matcovschi, Oleg
    >Cc: gregkh@linuxfoundation.org; linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; >Balbi, Felipe
    >Subject: Re: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events

    >Hi Oleg,

    >On Tue, Jul 3, 2012 at 11:09 PM, Matcovschi, Oleg <oleg.matcovschi@ti.com> wrote:
    >>>From: linux-omap-owner@vger.kernel.org
    >>>[linux-omap-owner@vger.kernel.org] on behalf of ABRAHAM, KISHON VIJAY
    >>>Sent: Friday, June 22, 2012 5:10 AM
    >>>To: gregkh@linuxfoundation.org; ABRAHAM, KISHON VIJAY;
    >>>linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org;
    >>>linux-usb@vger.kernel.org; Balbi, Felipe
    >>>Subject: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS
    >>>or ID events
    >>
    >>>The atomic notifier from twl4030/twl6030 to notifiy VBUS and ID
    >>>events, is replaced by a direct call to omap musb blue.
    >>
    >>>Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    >>>---
    >>> drivers/usb/musb/omap2430.c   |   94
    >>>+++++++++++++++++++++++++---------------
    >>> drivers/usb/otg/twl4030-usb.c |   46 ++++++++++----------
    >>>drivers/usb/otg/twl6030-usb.c |   47 +++++++++-----------
    >>>include/linux/usb/musb-omap.h |   30 +++++++++++++
    >>> 4 files changed, 133 insertions(+), 84 deletions(-) create mode
    >>>100644 include/linux/usb/musb-omap.h
    >> .....
    >> +enum omap_musb_vbus_id_status {
    >> +       OMAP_MUSB_UNKNOWN = 0,
    >> +       OMAP_MUSB_ID_GROUND,
    >> +       OMAP_MUSB_ID_FLOAT,
    >> +       OMAP_MUSB_VBUS_VALID,
    >> +       OMAP_MUSB_VBUS_OFF,
    >> +};
    >> +
    >>
    >> Why did you choose to introduce OMAP_MUSB specific VBUS, ID events?
    >> IMHO, it makes more sense to introduce mailbox functionality only without extra translation layer.
    >> Same mailbox glue layer could be used for other PHY drivers, not just twl.

    >We've decided to make twl as a comparator driver since we have a separate phy driver (not yet merged). Hence we dint >want twl to use usb_phy specific events. So if you have other PHY drivers, you can still use the OMAP_MUSB specific >events.
    >Thanks
    >Kishon

    In other words: you are proposing to have 2 flavors of other phy drivers(OMAP and not-OMAP platform specific)...
    Do you think it is necessary?
    Could you please provide full description of your original problem?

    Regards,
    Oleg
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-06 08:41    [W:0.028 / U:30.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site