[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 01/10] random: make 'add_interrupt_randomness()' do something sane
    On Thu, 2012-07-05 at 15:21 -0700, Linus Torvalds wrote:
    > On Thu, Jul 5, 2012 at 3:00 PM, Theodore Ts'o <> wrote:
    > >
    > > Like this?
    > Looks fine to me.
    > Although I think it might be better to stay closer to what we used to
    > do, and just 'or' in the action flags rather than make it some
    > conditional. And then at the end, do
    > if (!(flags & __IRQF_TIMER))
    > add_interrupt_randomness(irq)

    On systems with a timer interrupt and a sched_clock() that's
    asynchronous to it, this actually loses a great source of entropy for
    headless systems. Also: extra branch in fast path.

    It's better to mix and not credit than to not mix at all. Instead just
    check the fast count against HZ before the credit.

    Mathematics is the supreme nostalgia of our time.

     \ /
      Last update: 2012-07-06 00:41    [W:0.023 / U:35.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site