Messages in this thread | | | Date | Thu, 5 Jul 2012 10:22:30 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 04/23 v6] Input: atmel_mxt_ts - warn if sysfs could not be created |
| |
Hi Daniel, Henrik,
On Thu, Jun 28, 2012 at 09:08:05PM +0800, Daniel Kurtz wrote: > If sysfs entry creation fails, the driver is still usable, so don't > just abort probe. Just warn and continue. >
I understand that I am a bit late to the party :) but I do not agree with this change. Failure to create attributes is not sometihng that user could cause (at least not easily) and thus would not be a setup issue but something more severe. I believe we should fail loading the driver so sysfs attribute breakage will be noticed as soon as possible, instead of discovering it much much later in the process.
So I think we should revert this one.
Thanks.
-- Dmitry
| |