[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync
    Zhao Chenhui wrote:
    > If the guts node is missing, this code snippet will be skipped. If the guts node is existed,
    > the return value of of_iomap(), namely guts, will be tested. If it is NULL, it shows
    > that there is error in dts, or the ioremap() in of_iomap() failed. I think
    > these errors are fatal errors, so I print an error info and return.

    Ok, I see your point now. I'm concerned about what might happen if
    someone else updates mpc85xx_smp_init() in the future, but there's nothing
    actually wrong with your patch today.

    Timur Tabi
    Linux kernel developer at Freescale

     \ /
      Last update: 2012-07-05 19:21    [W:0.027 / U:2.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site