lkml.org 
[lkml]   [2012]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough
    Date
    On Tue,  3 Jul 2012 15:19:37 +0200, Paolo Bonzini <pbonzini@redhat.com> wrote:
    > This patch adds support for the new VIRTIO_BLK_F_CONFIG_WCE feature,
    > which exposes the cache mode in the configuration space and lets the
    > driver modify it. The cache mode is exposed via sysfs.
    >
    > Even if the host does not support the new feature, the cache mode is
    > visible (thanks to the existing VIRTIO_BLK_F_WCE), but not modifiable.
    >
    > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

    Fixed up some checkpatch warnings for you, too:

    virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:51: WARNING: please, no spaces at the start of a line
    #51: FILE: drivers/block/virtio_blk.c:424:
    + revalidate_disk(vblk->disk);$

    .virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:54: WARNING: static const char * array should probably be static const char * const
    #54: FILE: drivers/block/virtio_blk.c:427:
    +static const char *virtblk_cache_types[] = {

    .virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:160: ERROR: code indent should use tabs where possible
    #160: FILE: include/linux/virtio_blk.h:73:
    + /* writeback mode (if VIRTIO_BLK_F_CONFIG_WCE) */$

    .virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:161: ERROR: code indent should use tabs where possible
    #161: FILE: include/linux/virtio_blk.h:74:
    + __u8 wce;$

    .virtio:blk_allow_toggling_host_cache_between_writeback_and_writethrough.patch.new:161: WARNING: please, no spaces at the start of a line
    #161: FILE: include/linux/virtio_blk.h:74:
    + __u8 wce;$

    total: 2 errors, 3 warnings, 132 lines checked

    Cheers,
    Rusty.


    \
     
     \ /
      Last update: 2012-07-04 09:41    [W:0.034 / U:1.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site