lkml.org 
[lkml]   [2012]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lm8333: Fix check ordering
On Wed, 4 Jul 2012, Dmitry Torokhov wrote:

> > From: Alan Cox <alan@linux.intel.com>
> >
> > Fix harmless reference off end of array
> >
> > Reported-by: <dcb314@hotmail.com>
> > Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?43861
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > ---
> >
> > drivers/input/keyboard/lm8333.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
> > index ca168a6..081fd9e 100644
> > --- a/drivers/input/keyboard/lm8333.c
> > +++ b/drivers/input/keyboard/lm8333.c
> > @@ -91,7 +91,7 @@ static void lm8333_key_handler(struct lm8333 *lm8333)
> > return;
> > }
> >
> > - for (i = 0; keys[i] && i < LM8333_FIFO_TRANSFER_SIZE; i++) {
> > + for (i = 0; i < LM8333_FIFO_TRANSFER_SIZE && keys[i]; i++) {
> > pressed = keys[i] & 0x80;
> > code = keys[i] & 0x7f;
> >
> >
>
> I believe Jiri has already queued this through trivial tree...

Yup, it's in -next as 954bd6d1c. Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2012-07-05 00:01    [W:0.030 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site