lkml.org 
[lkml]   [2012]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] regulator: fixed: dt: support for input supply
On Wed, Jul 04, 2012 at 04:12:53PM +0530, Laxman Dewangan wrote:
> On Wednesday 04 July 2012 03:51 PM, Mark Brown wrote:
> >On Wed, Jul 04, 2012 at 12:32:08PM +0530, Laxman Dewangan wrote:

> >>In non-DT, the input supply is passed with the regulator_init_data
> >>through the fixed voltage config and it is filled in board files.

> >No, this is a legacy way of doing things. All regulators should be
> >moving to specifying the name in their descriptor except for supplies
> >that are power roots (which are often fixed voltage regulators).

> Then the input_supply should be set through the regulator init data
> "init_data->supply_regulator" rather than the desc? If yes then also
> I need to change the forthcoming patch for tps65910 and tps6586x to
> pass the supply_regulator through init_data.

No, exactly the opposite way round - it should be being set in the
descriptor. The issue with your patch was that it only allowed DT
systems to do this.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-07-04 13:41    [W:0.041 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site