Messages in this thread | | | Date | Wed, 4 Jul 2012 12:03:45 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [rfc 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file |
| |
On Wed, Jul 04, 2012 at 11:37:26AM +0400, Pavel Emelyanov wrote: > > > > -static ssize_t proc_fdinfo_read(struct file *file, char __user *buf, > > - size_t len, loff_t *ppos) > > -{ > > - char tmp[PROC_FDINFO_MAX]; > > - int err = proc_fd_info(file->f_path.dentry->d_inode, NULL, tmp); > > - if (!err) > > - err = simple_read_from_buffer(buf, len, ppos, tmp, strlen(tmp)); > > - return err; > > -} > > - > > I believe we can still have the proc_fdinfo_read and proc_fd_link code non-splitted. > Just push a callback pointer ino the proc_fd_info (as usual -- we an opaque void *argument).
Thanks! Will try.
Cyrill
| |