lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] perf kvm top: limit guest kernel info message to once
    Date
    'perf kvm top' shows a continual flurry of:
    Can't find guest [5201]'s kernel information

    if it can't find the guest info and with a lot of VMs running a user
    has no chance of reading them all. Limit message to once per guest.

    Signed-off-by: David Ahern <dsahern@gmail.com>
    Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    ---
    tools/perf/builtin-top.c | 13 +++++++++++--
    1 file changed, 11 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 35e86c6..0687c82 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -38,6 +38,7 @@
    #include "util/cpumap.h"
    #include "util/xyarray.h"
    #include "util/sort.h"
    +#include "util/intlist.h"

    #include "util/debug.h"

    @@ -706,8 +707,16 @@ static void perf_event__process_sample(struct perf_tool *tool,
    int err;

    if (!machine && perf_guest) {
    - pr_err("Can't find guest [%d]'s kernel information\n",
    - event->ip.pid);
    + static struct intlist *seen;
    +
    + if (!seen)
    + seen = intlist__new();
    +
    + if (!intlist__has_entry(seen, event->ip.pid)) {
    + pr_err("Can't find guest [%d]'s kernel information\n",
    + event->ip.pid);
    + intlist__add(seen, event->ip.pid);
    + }
    return;
    }

    --
    1.7.10.1


    \
     
     \ /
      Last update: 2012-07-31 07:02    [W:0.022 / U:29.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site